Bug 707097 - Add option to explicitly disable neon
Summary: Add option to explicitly disable neon
Status: RESOLVED FIXED
Alias: None
Product: GhostPDL
Classification: Unclassified
Component: Build Process (show other bugs)
Version: master
Hardware: ARM (Pi) Linux
: P2 enhancement
Assignee: Chris Liddell (chrisl)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-04 13:19 UTC by Benjamin
Modified: 2023-09-07 08:22 UTC (History)
0 users

See Also:
Customer:
Word Size: ---


Attachments
Patch which addresses the issue (2.84 KB, application/mbox)
2023-09-04 13:19 UTC, Benjamin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin 2023-09-04 13:19:57 UTC
Created attachment 24772 [details]
Patch which addresses the issue

Hi!

The attached patch should activate the already existing (but commented) "--disable-neon" ARG_ENABLE. From my point of view, the AC_LINK_IFELSE will always succeed, as the targeted cortex-a53 has mandatory NEON support. As I am not sure about that, I kept the check but extended it for the feature. This allows the builder to disable neon explicitly if the actual target-cpu does not support it.

Thanks & kind regards
Benjamin
Comment 1 Chris Liddell (chrisl) 2023-09-05 14:46:45 UTC
Thanks for reporting and attaching the patch here, much appreciated!

Would you mind just indulging my paranoia and double checking that everything looks as intended, before I push the change to our canonical repo, please?

https://git.ghostscript.com/?p=user/chrisl/ghostpdl.git;a=commitdiff;h=f67e47cc405f
Comment 2 Benjamin 2023-09-05 19:16:37 UTC
Hi, thanks for the fast feedback & response :) I diffed my branch against yours and configure.ac file is the same. So it looks good from my point of view.
Comment 3 Chris Liddell (chrisl) 2023-09-07 08:22:42 UTC
Thanks for double checking it for me.

Pushed:
https://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=fe77bc8af9cc


And, again, thanks for submitting the patch here.