Bug 697334 - Mupdf 1.10-rc1 crashes when entering pdf form fields
Summary: Mupdf 1.10-rc1 crashes when entering pdf form fields
Status: RESOLVED FIXED
Alias: None
Product: MuPDF
Classification: Unclassified
Component: mupdf (show other bugs)
Version: master
Hardware: Other Linux
: P4 normal
Assignee: MuPDF bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-11 08:37 UTC by fedir3
Modified: 2016-11-17 15:30 UTC (History)
2 users (show)

See Also:
Customer:
Word Size: ---


Attachments
tty-fix.patch (840 bytes, patch)
2016-11-11 08:37 UTC, fedir3
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fedir3 2016-11-11 08:37:18 UTC
Created attachment 13129 [details]
tty-fix.patch

Mupdf 1.10-rc1 will crash when filling pdf forms.
This issue already existed in 1.9 and Debian has put a patch in their package, disableing form filling.

The form filling function on Linux does not work anyway, as filling form fields will start a broken promt on the command line when started from such.
When started without it sometimes just crashes when entering forms.

Please consider using this patch (which will disable form input on X11 plattforms) to disable form filling on X11 until it is actually useful.
Comment 1 Tor Andersson 2016-11-14 06:10:49 UTC
How are you building? The default makefile on linux disables text input on X11 with -DDISABLE_TEXT_INPUT.
Comment 2 fedir3 2016-11-14 11:24:39 UTC
I used the PKGBUILD from archlinux and changed it to work with version 1.10 
https://bugs.archlinux.org/task/51793?getfile=14723

Original
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/mupdf


As far as I can see it simply runs "make build=release prefix="$pkgdir"/usr install"
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/mupdf#n68

This should include all the flags in the Makefile or does it not?
Comment 3 Robin Watts 2016-11-14 11:51:26 UTC
I don't speak PKGBUILD, so bear with me here...

That looks to me like it sets CFLAGS in the environment. That's bad as it will stop the Makefile logic from setting CFLAGS.

It should set XCFLAGS and leave CFLAGS unset.

Try changing all CFLAGS references to XCFLAGS references.
Comment 4 fedir3 2016-11-14 15:16:31 UTC
I don't think that adding to the CFLAGS variable will overwrite things in the Makefile.

Anyway I just compiled mupdf without the PKGBUILD (should have done that earlier)
and the problem still exists.

After downloading mupdf 1.10-rc1, unpacking it and running make, the resulting application mupdf-X11 still allows form filling and will crash as a result.

Note: The issue is not with the mupdf-gl version, just the X11 stuff which is used in must cases on linux distros.

So I suspect the flag does not work. Applying the debian patch and thereby simply disableing the few lines resposible for the prompt should do the trick as well I guess.
Comment 5 fedir3 2016-11-17 15:30:58 UTC
This issue is solved in mupdf-1.10-rc2
Thnaks