Bug 689331 - The pswrite device also needs the CRD stuff
Summary: The pswrite device also needs the CRD stuff
Status: RESOLVED WORKSFORME
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Build Process (show other bugs)
Version: master
Hardware: All All
: P4 normal
Assignee: Hin-Tak Leung
URL:
Keywords:
Depends on:
Blocks: 689315
  Show dependency tree
 
Reported: 2007-07-04 09:57 UTC by Till Kamppeter
Modified: 2010-07-28 04:39 UTC (History)
0 users

See Also:
Customer:
Word Size: ---

Attachments
Add missing CRD depoendency (1.24 KB, patch)
2007-07-04 09:58 UTC, Till Kamppeter 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Till Kamppeter 2007-07-04 09:57:51 UTC 
Build rule for pswrite in src/devs.mak misses gdevdcrdm, patch attached.
Comment 1 Till Kamppeter 2007-07-04 09:58:38 UTC 
Created attachment 3157 [details]
Add missing CRD depoendency
Comment 2 Ralph Giles 2007-07-10 09:58:30 UTC 
I don't see this dependency. Can you provide an example where the build fails?
Comment 3 Ray Johnston 2007-07-10 10:06:16 UTC 
The only external in gdevdcrd.c is sample_device_crd_get_params   
which is only used in these modules:   
src/gdevbit.c   
src/gdevdcrd.c   
src/gdevdcrd.h   
src/gdevdevn.c   
src/gdevrinkj.c   
src/gdevxcf.c   
   
All of these devices _should_ include the gdevdcrd.$(OBJ) in the   
dependency list   
   
The psd device has gdevcrd.h, but we don't know why (as well as some   
other modules that include it as well).
Comment 4 Hin-Tak Leung 2010-07-28 04:39:17 UTC 
I think Ray in comment 3 was right - the only external in gdevdcrd.c is sample_device_crd_get_params and it is not used by any of the pswrite or epswrite bits, so it is hard to see why the new dependency is needed.