| Summary: | Add option to explicitly disable neon | ||
|---|---|---|---|
| Product: | GhostPDL | Reporter: | Benjamin <benjamin.bara> |
| Component: | Build Process | Assignee: | Chris Liddell (chrisl) <chris.liddell> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | P2 | ||
| Version: | master | ||
| Hardware: | ARM (Pi) | ||
| OS: | Linux | ||
| Customer: | Word Size: | --- | |
| Attachments: | Patch which addresses the issue | ||
Thanks for reporting and attaching the patch here, much appreciated! Would you mind just indulging my paranoia and double checking that everything looks as intended, before I push the change to our canonical repo, please? https://git.ghostscript.com/?p=user/chrisl/ghostpdl.git;a=commitdiff;h=f67e47cc405f Hi, thanks for the fast feedback & response :) I diffed my branch against yours and configure.ac file is the same. So it looks good from my point of view. Thanks for double checking it for me. Pushed: https://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=fe77bc8af9cc And, again, thanks for submitting the patch here. |
Created attachment 24772 [details] Patch which addresses the issue Hi! The attached patch should activate the already existing (but commented) "--disable-neon" ARG_ENABLE. From my point of view, the AC_LINK_IFELSE will always succeed, as the targeted cortex-a53 has mandatory NEON support. As I am not sure about that, I kept the check but extended it for the feature. This allows the builder to disable neon explicitly if the actual target-cpu does not support it. Thanks & kind regards Benjamin