Bug 689331

Summary:	The pswrite device also needs the CRD stuff
Product:	Ghostscript	Reporter:	Till Kamppeter <till.kamppeter>
Component:	Build Process	Assignee:	Hin-Tak Leung <htl10>
Status:	RESOLVED WORKSFORME
Severity:	normal
Priority:	P4
Version:	master
Hardware:	All
OS:	All
Customer:		Word Size:	---
Bug Depends on:
Bug Blocks:	689315
Attachments:	Add missing CRD depoendency

Description Till Kamppeter 2007-07-04 09:57:51 UTC

Build rule for pswrite in src/devs.mak misses gdevdcrdm, patch attached.

Comment 1 Till Kamppeter 2007-07-04 09:58:38 UTC

Created attachment 3157 [details]
Add missing CRD depoendency

Comment 2 Ralph Giles 2007-07-10 09:58:30 UTC

I don't see this dependency. Can you provide an example where the build fails?

Comment 3 Ray Johnston 2007-07-10 10:06:16 UTC

The only external in gdevdcrd.c is sample_device_crd_get_params   
which is only used in these modules:   
src/gdevbit.c   
src/gdevdcrd.c   
src/gdevdcrd.h   
src/gdevdevn.c   
src/gdevrinkj.c   
src/gdevxcf.c   
   
All of these devices _should_ include the gdevdcrd.$(OBJ) in the   
dependency list   
   
The psd device has gdevcrd.h, but we don't know why (as well as some   
other modules that include it as well).

Comment 4 Hin-Tak Leung 2010-07-28 04:39:17 UTC

I think Ray in comment 3 was right - the only external in gdevdcrd.c is sample_device_crd_get_params and it is not used by any of the pswrite or epswrite bits, so it is hard to see why the new dependency is needed.