Bug 697184 - pdf_drop_js is missing in pdf-js-none.c
Summary: pdf_drop_js is missing in pdf-js-none.c
Status: RESOLVED WORKSFORME
Alias: None
Product: MuPDF
Classification: Unclassified
Component: mupdf (show other bugs)
Version: unspecified
Hardware: Other All
: P4 normal
Assignee: MuPDF bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-02 09:38 UTC by fedir3
Modified: 2016-10-05 10:33 UTC (History)
1 user (show)

See Also:
Customer:
Word Size: ---

Attachments
fixed version of pdf-js-none.c (503 bytes, text/x-csrc)
2016-10-02 09:38 UTC, fedir3 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fedir3 2016-10-02 09:38:38 UTC 
Created attachment 12984 [details]
fixed version of pdf-js-none.c

pdf-js-none.c implements dummy functions from javascript.h but misses the pdf_drop_js function.

When compiling mupdf with HAVE_MUJS := no, the compilation fails because of pdf-xref.c using an undefined reference to `pdf_drop_js'

adding the missing dummy function solves the issue.
see attached fix
Comment 1 Robin Watts 2016-10-05 10:33:54 UTC 
In the latest version, pdf-js.c has both js and no-js versions, controlled by the FZ_ENABLE_JS define.