Bug 694767 - Add support for FreeMiNT systems to triodef.h
Summary: Add support for FreeMiNT systems to triodef.h
Status: RESOLVED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Build Process (show other bugs)
Version: 9.10
Hardware: PC Linux
: P4 normal
Assignee: Chris Liddell (chrisl)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-09 06:46 UTC by Alan Hourihane
Modified: 2013-11-11 09:33 UTC (History)
0 users

See Also:
Customer:
Word Size: ---


Attachments
Add FreeMiNT support. (347 bytes, patch)
2013-11-09 06:46 UTC, Alan Hourihane
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Hourihane 2013-11-09 06:46:22 UTC
Created attachment 10379 [details]
Add FreeMiNT support.

Patch attached. Thanks.
Comment 1 Chris Liddell (chrisl) 2013-11-11 04:33:54 UTC
I would rather handle cases like this via the configure script. Something like this:

http://git.ghostscript.com/?p=user/chrisl/ghostpdl.git;a=commitdiff;h=beb7dcb6


If you could give that a try, and see if it suits....
Comment 2 Alan Hourihane 2013-11-11 08:39:58 UTC
There's a typo for the log10l test, it's currently...

AC_CHECK_FUNC([log10], [TRIO_NO_LOG10L=""], [TRIO_NO_LOG10L="-DTRIO_NO_LOG10L"])

It should be...

AC_CHECK_FUNC([log10l], [TRIO_NO_LOG10L=""], [TRIO_NO_LOG10L="-DTRIO_NO_LOG10L"])
Comment 3 Alan Hourihane 2013-11-11 08:40:33 UTC
Also, Cygwin defines these in the trio header file, so it's probably worthy of a cleanup there too.
Comment 4 Chris Liddell (chrisl) 2013-11-11 08:47:42 UTC
Thanks for the correction above.... I've fixed that.

(In reply to comment #3)
> Also, Cygwin defines these in the trio header file, so it's probably worthy
> of a cleanup there too.

That's how trio "ships" - so far we've avoided making changes in the trio source, and although I'm much less averse to changing trio than other third party libs (I doubt trio is going to change), I'd rather not change the source if we don't have to.
Comment 5 Chris Liddell (chrisl) 2013-11-11 08:55:58 UTC
I've committed the configure changes (with the typo fixed):

http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=f9774c5a
Comment 6 Alan Hourihane 2013-11-11 09:18:56 UTC
Thanks Chris !
Comment 7 Chris Liddell (chrisl) 2013-11-11 09:33:17 UTC
(In reply to comment #6)
> Thanks Chris !

No problem....