Bug 693547 - Link handling for generic urls
Summary: Link handling for generic urls
Status: RESOLVED FIXED
Alias: None
Product: MuPDF
Classification: Unclassified
Component: mupdf (show other bugs)
Version: master
Hardware: Android Phone Android
: P4 enhancement
Assignee: Tor Andersson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-10 20:17 UTC by André Ferreira
Modified: 2013-01-11 15:42 UTC (History)
1 user (show)

See Also:
Customer:
Word Size: ---

Attachments
Patch (2.78 KB, application/octet-stream)
2013-01-10 20:17 UTC, André Ferreira 		Details
Same patch but includes suggestion that highlighting is not required to trigger a hyperlink (2.76 KB, application/octet-stream)
2013-01-10 20:19 UTC, André Ferreira 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description André Ferreira 2013-01-10 20:17:22 UTC 
Created attachment 9205 [details]
Patch

This patch adds support for external hyperlinks.

Additionally, clicking a hyperlink that's inside the margin bounds will now target the hyperlink instead of moving between pages.

As a suggestion, I'd like to be able to click the hyperlink without highlighting them first.

To do so, replace:

} else if (mLinkHighlight && pageView != null

with:

} else if (pageView != null
Comment 1 André Ferreira 2013-01-10 20:19:10 UTC 
Created attachment 9206 [details]
Same patch but includes suggestion that highlighting is not required to trigger a hyperlink
Comment 2 Robin Watts 2013-01-11 15:42:29 UTC 
A slightly tweaked version of the first patch has now been committed. Thanks!