Bug 692990 - Non painted parts in thick lines (operator "l")
Summary: Non painted parts in thick lines (operator "l")
Status: RESOLVED FIXED
Alias: None
Product: MuPDF
Classification: Unclassified
Component: mupdf (show other bugs)
Version: unspecified
Hardware: PC Linux
: P4 normal
Assignee: Tor Andersson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-17 18:11 UTC by Sergey Khlutchin
Modified: 2012-04-19 07:44 UTC (History)
1 user (show)

See Also:
Customer:
Word Size: ---


Attachments
example file with thick and thin lines (6.21 KB, application/pdf)
2012-04-17 18:11 UTC, Sergey Khlutchin
Details
The result of mudraw with the first file (23.61 KB, image/png)
2012-04-17 18:22 UTC, Sergey Khlutchin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Khlutchin 2012-04-17 18:11:39 UTC
Created attachment 8532 [details]
example file with thick and thin lines

Some lines with bevel join and butt cap have a non painted parts, when the thickness is more then the length of segments. See pdf with the mupdf version 1.0rc1.
Comment 1 Sergey Khlutchin 2012-04-17 18:22:51 UTC
Created attachment 8533 [details]
The result of mudraw with the first file

Thin line has the some points but small thickness
Comment 2 Robin Watts 2012-04-18 18:20:11 UTC
This is the mupdf equivalent of bug 688655. Testing a fix now.
Comment 3 Sergey Khlutchin 2012-04-18 20:27:05 UTC
(In reply to comment #2)
> This is the mupdf equivalent of bug 688655. Testing a fix now.

i think it explain "rough" joins but not the unpainted centerline.
Comment 4 Robin Watts 2012-04-18 23:40:45 UTC
Fixed in:


commit 7aa46e79f2f4994ec94aa94d4a1129e10b6cbd4d
Author: Robin Watts <robin.watts@artifex.com>
Date:   Wed Apr 18 16:24:57 2012 +0100

    Bug 692990: Fix 'underjoin' of strokes.

    See Bug 688655 for analysis of what we SHOULD be doing. The code changes
    to do this are actually quite small.

    Essentially, when we join we only draw the 'top' (or 'outer') join in a
    join dependent way. The 'under' join was always joined as a bevel before
    as this was easy. This produces bad effects when the lines have a
    significant angle between them and a large linewidth.

    The correct (i.e. matching Acrobat and others) way to work is to
    join the bottom of the line via the centre point. The sole exception
    to this is when drawing under beziers, as we don't want to make our
    approximation-by-lines obvious.

    All fixed in this patch.

Thanks for the report.
Comment 5 Sergey Khlutchin 2012-04-19 05:42:45 UTC
(In reply to comment #4)
> Fixed in:
> 
> 
> commit 7aa46e79f2f4994ec94aa94d4a1129e10b6cbd4d

>     All fixed in this patch.
> 
> Thanks for the report.

how to obtain the patch?
The link shows "404 - Unknown commit object"
Comment 6 Sergey Khlutchin 2012-04-19 07:44:01 UTC
It works! Thanks!