Bug 691992 - patch to configure.ac in gs 9.01 to simplify adding new devices
Summary: patch to configure.ac in gs 9.01 to simplify adding new devices
Status: RESOLVED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Build Process (show other bugs)
Version: master
Hardware: PC Linux
: P4 normal
Assignee: Chris Liddell (chrisl)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-21 01:57 UTC by William Bader
Modified: 2011-09-14 12:48 UTC (History)
2 users (show)

See Also:
Customer:
Word Size: ---

Attachments
patch to simplify adding new devices (483 bytes, application/octet-stream)
2011-02-21 01:57 UTC, William Bader 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description William Bader 2011-02-21 01:57:39 UTC 
Created attachment 7270 [details]
patch to simplify adding new devices

This patch to configure.ac in gs 9.01 makes it easier to add new devices and configure them using --with-drivers.
With this patch, you can run
  ./configure --with-drivers=ALL,USER:mydriver
The result of USER:mydriver is adding $(DD)mydriver.dev to DEVICE_DEVS2 in Makefile.  You still need to write the driver and add a sequence like the one below to devs.mak.
mydriver_=$(GLOBJ)gdevmydriver.$(OBJ)
$(DD)mydriver.dev: $(mydriver_)
        $(SETDEV) $(DD)mydriver $(mydriver_)
$(GLOBJ)gdevmydriver.$(OBJ): $(GLSRC)gdevmydriver.c $(GDEV)
        $(GLCC) $(GLO_)gdevmydriver.$(OBJ) $(C_) $(GLSRC)gdevmydriver.c
Comment 1 Chris Liddell (chrisl) 2011-03-14 08:16:24 UTC 
I think you're actually partially fixing a bug in the 9.01 configure script - but correct me if I'm wrong.

There is a bug (my fault) that meant individual driver requests didn't get the $(DD) prepended and .dev appended as they were supposed to.

The intended functionality is that:

./configure --with-drivers=splodge

would result in a line:
DEVICE_DEVS2=$(DD)splodge.dev

in the Makefile. That would satisfy your requirement, wouldn't it?

Thanks.
Comment 2 William Bader 2011-03-14 22:34:11 UTC 
>That would satisfy your requirement, wouldn't it?

Yes, I only want to have a way on the configure command line to add $(DD)mydriver.dev to one of the DEVICE_DEV line.
Comment 3 Chris Liddell (chrisl) 2011-09-14 12:48:30 UTC 
It does seem to be largely a problem with the bug I mentioned in the 9.01 configure.

With the fixed version you can do:
./configure --with-drivers=ALL,mydriver

And you end up with "$(DD)mydriver.dev" in the Makefile.