Bug 689498 - Need tests for custom color callback.
Summary: Need tests for custom color callback.
Status: RESOLVED LATER
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Graphics Library (show other bugs)
Version: 0.00
Hardware: PC Windows XP
: P5 enhancement
Assignee: Marcos H. Woehrmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-04 10:51 UTC by leonardo
Modified: 2009-11-09 10:16 UTC (History)
0 users

See Also:
Customer:
Word Size: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description leonardo 2007-10-04 10:51:49 UTC
When fixing an "out of buffer crash" few monthes ago, pdf14_put_image was 
improved with accounting the 'rect'. Now we noticed that 
pdf14_cmykspot_put_image and pdf14_custom_put_image still have same problem. I 
do know how to fix that, but I have no test suits for debugging it. So giving  
to Ray : please give us a test case, which Dan should have had somewhere when 
coded these functions. If no test suits available, please pass it back to me 
with a comment how to make them.
Comment 1 leonardo 2007-10-04 10:52:56 UTC
Setting P2 because it's a part of the current project, and it's a crash when 
somebody will call these functions.
Comment 2 leonardo 2007-10-04 11:08:33 UTC
pdf14_put_image was improved with revision 7064. pdf14_cmykspot_put_image and 
pdf14_custom_put_image were added by revision 7795 as a merge from the custom 
color callback branch. That branch missed the improvement 7064 due to branching 
before it.
Comment 3 leonardo 2007-10-10 01:16:43 UTC
Patch to HEAD :
http://ghostscript.com/pipermail/gs-cvs/2007-October/007858.html

The patch was not tested at all. We don't close the bug now because it still 
requires an appropriate testing. Please provide test cases which involves 
pdf14_cmykspot_put_image and pdf14_custom_put_image. Likely the test file of 
the bug 688631 can help.
Comment 4 Ray Johnston 2007-10-10 09:16:25 UTC
Thanks for the patch. I have test files for this (from customer 190) and am
working on other problems with the transparency code going to cmykspot devices.
Comment 5 Henry Stiles 2007-10-10 14:16:59 UTC
Reassigning back to Leo.  Ray please add test files (ref comment #4) and provide
build instructions for custom color callback code.  Thanks.
Comment 6 leonardo 2007-11-06 10:43:39 UTC
Assigning back to Ray. Ray please follow comment #5.
Comment 7 leonardo 2008-03-05 12:57:12 UTC
Changing the bug title for a better reflection of the problem. The old one 
is "transparency: The buffer backdroping code can write outside bufers.".
Comment 8 Ray Johnston 2009-03-17 14:56:09 UTC
As with other requests for extended testing of some compiled in modes, I
am assigning to Marcos, at the appropriate priority.

Note that this isP5 since Michael's new ICC color workflow will deprecate the
custom color callback as it exists today.