Bug 687907 - PATCH: KRGB support for the "ijs" device
Summary: PATCH: KRGB support for the "ijs" device
Status: NOTIFIED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Printer Driver (show other bugs)
Version: 8.16
Hardware: All All
: P2 major
Assignee: Ralph Giles
URL: http://hpinkjet.sourceforge.net/
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-21 08:28 UTC by Till Kamppeter
Modified: 2008-12-19 08:31 UTC (History)
2 users (show)

See Also:
Customer:
Word Size: ---


Attachments
Patch developed by HP to introduce KRGB support to the "ijs" device. (19.22 KB, patch)
2005-01-21 08:30 UTC, Till Kamppeter
Details | Diff
the corrected(?) krgb patch, updated for ghostscript 8.50/8.51 (20.06 KB, patch)
2005-04-21 18:20 UTC, Hin-Tak Leung
Details | Diff
gdevijs-krgb-1.2-gs8.50.patch (22.41 KB, patch)
2006-03-07 08:58 UTC, Hin-Tak Leung
Details | Diff
The v1.2 patch for AFPL gs 8.53 (21.91 KB, patch)
2006-03-07 09:01 UTC, Hin-Tak Leung
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Till Kamppeter 2005-01-21 08:28:36 UTC
The newer HP inkjet printers do their color management inside their hardware. So
in principle they print with raw RGB and not with CMYK as most other inkjet
printers. But to enhance quality and to make the devices more economic with ink
HP also sends the information which areas are really black in the document so
that there the black ink is used and not the three colored inks or even all four
inks. So so-called KRGB has to be sent to the HP printers to get the best out of
them. HP's HPIJS driver supports this when it gets KRGB as input from the "ijs"
device.

The patch attached to this report are HP's changes to add KRGB to the "ijs"
device. It applies only to src/gdevijs.c. No warnings appear during compilation
of src/gdevijs.src after the patch is applied.
Comment 1 Till Kamppeter 2005-01-21 08:30:15 UTC
Created attachment 1175 [details]
Patch developed by HP to introduce KRGB support to the "ijs" device.

See initial posting. The patch fixes this issue.
Comment 2 Jack Moffitt 2005-01-24 12:27:40 UTC
This would be something for the GPL Ghostscript release I assume, so assigning
to Ralph.  But perhaps it should go to Raph for approval.
Comment 3 Ralph Giles 2005-01-24 17:22:59 UTC
I suppose we should support this, although the patch is flawed. HP only saw fit
to implement 1 bit of K plane, but it should support other depths as well. This
is essentially object tagging and so there might be desire for other flags, and
as well many (non-HP) inkjet devices have variable dot size and require more
than one bit for proper control.
Comment 4 Raph Levien 2005-01-26 10:02:07 UTC
The best contact at HP for this is probably David Suffield, the author of the
patch. His email address is of the form firstname_lastname@hp.com.
Comment 5 Till Kamppeter 2005-01-27 09:52:43 UTC
Contact also Cory Meisch, cory dot meisch at hp dot com.
Comment 6 Till Kamppeter 2005-02-14 13:29:12 UTC
Below is David Suffield's answer to this issue.

--------------------------------------------------------------------------
I have no problem with > 1-bit K plane support in Ghostscript. As long
as it still meets the definition of KRGB. For example:

KRGB definition:
1. K=1-bit to 8-bit black plane, RGB=24 bit color raster.
2. K-plane will contain objects that are black text and black line
drawings.
3. RGB raster will _not_ contain K-plane objects.
4. K resolution and RGB resolution would be equal.
5. K-plane will be byte aligned.
6. K-plane bit definition; 0xff=black, 0=white.

We could negotiate K-plane bit depth over the IJS bus and default to
1-bit K-plane for backward compatibility.

I believe this was the general consensus that was reached a while back
on the inkjet-list. Getting KRGB support up-stream into GPL Ghostscript
8.x would be a big help. 

-dave
Comment 7 Hin-Tak Leung 2005-04-21 18:14:35 UTC
Please note the attached patch is flawed - it breaks DeviceGray
ijs devices like epsonepl. There is an updated patch after Feb 20, 2005.
Comment 8 Hin-Tak Leung 2005-04-21 18:20:36 UTC
Created attachment 1330 [details]
the corrected(?) krgb patch, updated for ghostscript  8.50/8.51

Obsoleting the previous patch, as it breaks epsonepl, and it is 
out-dated as there is an updated one for gs 8.15 in hpijs source
after feb 20, 2005. Also, the gs_malloc/gs_free macros have changed 
between gs 8.15 and 8.50; the attached patch is for gs 8.50/8.51 , 
modified from the updated patch for 8.15.
Comment 9 Hin-Tak Leung 2006-03-07 08:58:35 UTC
Created attachment 2080 [details]
gdevijs-krgb-1.2-gs8.50.patch

New upstream release of the patch for GPL gs 8.50
Comment 10 Hin-Tak Leung 2006-03-07 09:01:35 UTC
Created attachment 2081 [details]
The v1.2 patch for AFPL gs 8.53

the v1.2 patch, corrected for gs 8.53 - one hunk is obsolete and removed 
due to parallel bug fixes, another adjusted due to modification in 
surrounding code between 8.50 and 8.53.
Comment 11 Henry Stiles 2007-10-16 13:13:28 UTC
Reassigning to community liaison.
Comment 12 Till Kamppeter 2008-01-23 06:29:51 UTC
HP has posted a new patch now where bug 689065 is fixed. I have applied this
patch to the Ghostscript SVN repository, rev 8497.