Bug 694535

Summary:	Typo in charset conversion in gdevpdfe.c
Product:	Ghostscript	Reporter:	Tim Waugh <twaugh>
Component:	PDF Writer	Assignee:	Ken Sharp <ken.sharp>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P4
Version:	9.07
Hardware:	PC
OS:	Linux
Customer:		Word Size:	---
Attachments:	ghostscript-pdf-charset-conv.patch

Description Tim Waugh 2013-08-22 07:51:18 UTC

Created attachment 10134 [details]
ghostscript-pdf-charset-conv.patch

ps2pdf14 fails when trying to write the metadata, for some values. This is due to a typo.

Original report:
  https://bugzilla.redhat.com/show_bug.cgi?id=999927

Comment 1 Ken Sharp 2013-08-22 08:08:50 UTC

(In reply to comment #0)
> Created attachment 10134 [details]
> ghostscript-pdf-charset-conv.patch
> 
> ps2pdf14 fails when trying to write the metadata, for some values. This is
> due to a typo.

And the typo is ?....

Comment 2 Tim Waugh 2013-08-22 09:32:31 UTC

See the attached patch. "buf0[0]" in the loop should be "buf0[i]", and there are a couple of instances of that.

Comment 3 Ken Sharp 2013-08-22 09:38:11 UTC

(In reply to comment #2)
> See the attached patch. "buf0[0]" in the loop should be "buf0[i]", and there
> are a couple of instances of that.

Ah I missed the patch, thanks

Comment 4 Ken Sharp 2013-08-23 01:18:26 UTC

Thanks for the investigation and the patch! I've applied it in commit
c1510d726063080559e9597db7d4a686f2ca4eae

I'd be grateful if you could review that and check the test file, just for independent confirmation.

Comment 5 Tim Waugh 2013-08-28 04:41:42 UTC

Works here. Thanks.