Bug 694535 - Typo in charset conversion in gdevpdfe.c
Summary: Typo in charset conversion in gdevpdfe.c
Status: RESOLVED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: PDF Writer (show other bugs)
Version: 9.07
Hardware: PC Linux
: P4 normal
Assignee: Ken Sharp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-22 07:51 UTC by Tim Waugh
Modified: 2013-08-28 04:41 UTC (History)
0 users

See Also:
Customer:
Word Size: ---

Attachments
ghostscript-pdf-charset-conv.patch (927 bytes, patch)
2013-08-22 07:51 UTC, Tim Waugh 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Waugh 2013-08-22 07:51:18 UTC 
Created attachment 10134 [details]
ghostscript-pdf-charset-conv.patch

ps2pdf14 fails when trying to write the metadata, for some values. This is due to a typo.

Original report:
  https://bugzilla.redhat.com/show_bug.cgi?id=999927
Comment 1 Ken Sharp 2013-08-22 08:08:50 UTC 
(In reply to comment #0)
> Created attachment 10134 [details]
> ghostscript-pdf-charset-conv.patch
> 
> ps2pdf14 fails when trying to write the metadata, for some values. This is
> due to a typo.

And the typo is ?....
Comment 2 Tim Waugh 2013-08-22 09:32:31 UTC 
See the attached patch. "buf0[0]" in the loop should be "buf0[i]", and there are a couple of instances of that.
Comment 3 Ken Sharp 2013-08-22 09:38:11 UTC 
(In reply to comment #2)
> See the attached patch. "buf0[0]" in the loop should be "buf0[i]", and there
> are a couple of instances of that.

Ah I missed the patch, thanks
Comment 4 Ken Sharp 2013-08-23 01:18:26 UTC 
Thanks for the investigation and the patch! I've applied it in commit
c1510d726063080559e9597db7d4a686f2ca4eae

I'd be grateful if you could review that and check the test file, just for independent confirmation.
Comment 5 Tim Waugh 2013-08-28 04:41:42 UTC 
Works here. Thanks.