| Summary: | Patches for libpng14, Cygwin/MinGW | ||
|---|---|---|---|
| Product: | jbig2dec | Reporter: | Yaakov (Cygwin Ports) <yselkowitz> |
| Component: | Build Process | Assignee: | Chris Liddell (chrisl) <chris.liddell> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | christinedelight.top85, henry.stiles, vincent.torri |
| Priority: | P4 | ||
| Version: | master | ||
| Hardware: | PC | ||
| OS: | other | ||
| Customer: | Word Size: | --- | |
| Attachments: |
Fix compatibilty with libpng14
Only link jbig2dec against libpng Fix shared library linkage on PE platforms |
||
Created attachment 6657 [details]
Only link jbig2dec against libpng
Created attachment 6658 [details]
Fix shared library linkage on PE platforms
* for libpng, use PKG_CONFIG_PATH, it's easier and gives you always the correct link flags * for the DLL, I have filed a bug before reading that bug report. However, that patch is not complete (see #691784) (In reply to comment #3) > * for the DLL, I have filed a bug before reading that bug report. However, > that patch is not complete (see #691784) My patch is sufficient for Cygwin, which does not require AC_LIBTOOL_WIN32_DLL. I cannot say with certainty for other PE platforms. Well, it was not obvious that you were patching only for cygwin, according to the subject of the bug report :-) For MinGW, it's necessary (see libtool manual). I didn't know that cygwin does not need it. The first patch I had either done myself or from another bug report, but the other two have been committed: http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=19dc7b85 Thanks! |
Created attachment 6656 [details] Fix compatibilty with libpng14