Bug 691555 - Patches for libpng14, Cygwin/MinGW
Summary: Patches for libpng14, Cygwin/MinGW
Status: RESOLVED FIXED
Alias: None
Product: jbig2dec
Classification: Unclassified
Component: Build Process (show other bugs)
Version: master
Hardware: PC other
: P4 normal
Assignee: Chris Liddell (chrisl)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 05:28 UTC by Yaakov (Cygwin Ports)
Modified: 2013-05-07 15:03 UTC (History)
3 users (show)

See Also:
Customer:
Word Size: ---

Attachments
Fix compatibilty with libpng14 (1.06 KB, patch)
2010-08-13 05:28 UTC, Yaakov (Cygwin Ports) 		Details | Diff
Only link jbig2dec against libpng (1.73 KB, patch)
2010-08-13 05:28 UTC, Yaakov (Cygwin Ports) 		Details | Diff
Fix shared library linkage on PE platforms (1.11 KB, patch)
2010-08-13 05:29 UTC, Yaakov (Cygwin Ports) 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yaakov (Cygwin Ports) 2010-08-13 05:28:23 UTC 
Created attachment 6656 [details]
Fix compatibilty with libpng14
Comment 1 Yaakov (Cygwin Ports) 2010-08-13 05:28:51 UTC 
Created attachment 6657 [details]
Only link jbig2dec against libpng
Comment 2 Yaakov (Cygwin Ports) 2010-08-13 05:29:45 UTC 
Created attachment 6658 [details]
Fix shared library linkage on PE platforms
Comment 3 vincent.torri 2010-11-21 22:01:59 UTC 
 * for libpng, use PKG_CONFIG_PATH, it's easier and gives you always the correct link flags

 * for the DLL, I have filed a bug before reading that bug report. However, that patch is not complete (see #691784)
Comment 4 Yaakov (Cygwin Ports) 2010-11-22 18:12:03 UTC 
(In reply to comment #3)
>  * for the DLL, I have filed a bug before reading that bug report. However,
> that patch is not complete (see #691784)

My patch is sufficient for Cygwin, which does not require AC_LIBTOOL_WIN32_DLL.  I cannot say with certainty for other PE platforms.
Comment 5 vincent.torri 2010-11-22 21:14:43 UTC 
Well, it was not obvious that you were patching only for cygwin, according to the subject of the bug report :-) For MinGW, it's necessary (see libtool manual). I didn't know that cygwin does not need it.
Comment 6 Chris Liddell (chrisl) 2013-05-07 15:03:29 UTC 
The first patch I had either done myself or from another bug report, but the other two have been committed:

http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=19dc7b85


Thanks!