Summary: | Journalling issue with undo | ||
---|---|---|---|
Product: | MuPDF | Reporter: | Jamie Lemon <jamie.lemon> |
Component: | mupdf | Assignee: | Robin Watts <robin.watts> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | master | ||
Hardware: | PC | ||
OS: | All | ||
Customer: | Word Size: | --- |
Description
Jamie Lemon
2024-09-23 15:38:32 UTC
I think the short answer to this is that I hadn't expected to be able to undo across page deletions. Undo/Redo works by capturing PDF object changes. I think page deletion probably changes data structures other than pdf objects, and so undoing doesn't put those back. This is definitely a bug, as (at the very least) the page deletion should clear th undo history. I will have to investigate for a bit to see if I can make undo work with page deletion. commit 24319da56b1b52585ba996edae8a91d195c3f91b Author: Tor Andersson <tor.andersson@artifex.com> Date: Wed Sep 25 16:44:14 2024 +0200 Bug 708052: Fix life times of objects during undo/redo. Update live pdf_page and pdf_annot objects when reordering pages and using undo and redo. Any pdf_page and pdf_annot objects that point to pages and annotations that are no longer in the document after undo are neutralized by setting the internal pdf_obj pointer to NULL. |