Summary: | Can't build THREADSAFE Ghostscript Release DLL with Visual Studio | ||
---|---|---|---|
Product: | Ghostscript | Reporter: | Dave Miller <davadev77> |
Component: | Build Process | Assignee: | Chris Liddell (chrisl) <chris.liddell> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sphinx.pinastri |
Priority: | P4 | ||
Version: | 9.53.0 | ||
Hardware: | PC | ||
OS: | Windows 10 | ||
Customer: | Word Size: | --- | |
Attachments: | Patch |
Description
Dave Miller
2020-09-16 09:19:05 UTC
Created attachment 19841 [details]
Patch
There are several ways to fix this:
Since local versions of errprintf_nomem() and errprintf() are mostly identical,
one can just call errprintf() with a dummy mem argument. This approach is implemented in the attached patch.
One can also keep errprintf_nomem() in all cases, because mkromfs does not need thread safety, and the local version of errprintf_nomem() is thread safe anyway.
It is also possible to use call fprintf(stderr, ...) directly in mkromfs and reduce the level of indirection and confusion even more.
Sorry, Chris. BTW, I can force this same error on linux (so Chris doesn't have to mess with linux) using: make XCFLAGSAUX=-DGS_THREADSAFE Slightly tweaked patch applied in: https://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=0ca4ae94020a Thanks |