Bug 701492

Summary:	muso: Toolbar menu can unnecessarily scroll sideways and hide toolbar buttons
Product:	MuPDF	Reporter:	Sebastian Rasmussen <sebastian.rasmussen>
Component:	AppKit	Assignee:	Fred Ross-Perry <fred.ross-perry>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	jamie.lemon, paul.gardiner
Priority:	P4
Version:	master
Hardware:	Android Phone
OS:	Android
Customer:		Word Size:	---
Attachments:	Android - needlessly scroll ribbon by dragging icon

Description Sebastian Rasmussen 2019-09-05 23:40:14 UTC

a. start "MuPDF Test"
b. click "Full Document Editor"
c. click "samples"
d. click "pdf-with-table-of-contents.pdf"
e. click on the hamburger menu and then ANNOTATE
f. it is possible to scroll the menu sideways even though it fits on screen

This is a problem because users may accidentally do this without realizing causing the toolbar buttons to be hidden outside of the screen. The same also possible with the FILE and PAGES toolbars, but not with the REDACTION toolbar.

The fact that it can be scrolled is not very obvious from the UI, and if it is not necessary due to screen real estate, we should probably not allow it to scroll.

Comment 1 Sebastian Rasmussen 2019-09-06 10:19:04 UTC

https://ghostscript.com/~sebras/testing/mupdf/toolbar-annotate-initial.png
https://ghostscript.com/~sebras/testing/mupdf/toolbar-annotate-scrolled.png
https://ghostscript.com/~sebras/testing/mupdf/toolbar-file-initial.png
https://ghostscript.com/~sebras/testing/mupdf/toolbar-file-scrolled.png
https://ghostscript.com/~sebras/testing/mupdf/toolbar-pages-initial.png
https://ghostscript.com/~sebras/testing/mupdf/toolbar-pages-scrolled.png

Among these six screenshots I try to illustrate how the toolbar can be scrolled outside of the screen on my phone. All toolbars fit on screen on my phone, in both landscape and portrait orientation but landscape orientation is used here that has lots of horizontal real estate, so there shouldn't be any need for scrolling in this case. On my tablet the toolbar can never be scrolled regardless of orientation. I can see how having scrollable toolbars make sense if horizontal real estate is tight, but in these cases it isn't so I feel this is a UI-issue where users might accidentally hide toolbar icons and then not being able to find them since it is not that obvious that the toolbars can be scrolled.

Comment 2 Paul Gardiner 2019-09-11 15:30:06 UTC

I don't think this happens in the iOS version

Comment 3 Jamie Lemon 2021-06-14 15:44:23 UTC

Created attachment 21070 [details]
Android - needlessly scroll ribbon by dragging icon

Comment 4 Jamie Lemon 2021-06-14 15:45:25 UTC

Confirmed, this is only an issue on Android on the phone (couldn't replicate on tablet)

You don't require to open a PDF with a Table of Contents in order to do this, you just need to press hold on a ribbon icon and drag left & right.

See attached video.