| Summary: | Radial gradient (sh /ShadingType 3) should appear circular, not as 32-sided polygon | ||
|---|---|---|---|
| Product: | MuPDF | Reporter: | Paul Sladen <mupdf> |
| Component: | mupdf | Assignee: | Robin Watts <robin.watts> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | tor.andersson |
| Priority: | P4 | ||
| Version: | unspecified | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Customer: | Word Size: | --- | |
|
Description
Paul Sladen
2013-05-20 05:44:38 UTC
In Fitz: fitz/res_shade.c:166: /* FIXME: Nasty */ #define RADSEGS 32 /* how many segments to generate for radial meshes */ this is then used immediately after in fz_paint_annulus() calling fz_point_on_circle() to generate quard coordinates from inner radius to outer radius, using a step size. This is thus slightly harder, since the flattening precision suitable for the outer radius will generally be finer than for the inner radius. To keep the generated coordinates collinear at each radius either (a) the subdivisions need to be evaluated per the flattening suitable for the outer-most radius, or when the flattening for the inner and outer is different additional quads need to be generated, which is somewhat hard, but easier if locked to a multiple of the inner radius-flattening (eg. power-of-two). From a code point of view it would be easier to only using the flattening level for the outer-most annulus radius, but then this needs to be known, and thus recorded in advance even when rendering the inner annulus slices. I've tried an adaptive calculation of the number of segments based on the matrix scaling factor and gradient radius... the problem with this approach is that adjacent shadings (where the inner radius of one shading touches the outer radius of another) end up having different number of segments, and this leads to cracks between them. The ideal approach would be to render radial shadings directly without tesselating them into triangles. Mostly fixed in commit eac3d6f4db3ba06637c02fd7aa3b69bafb1b6e81 Author: Tor Andersson <tor.andersson@artifex.com> Date: Thu May 1 14:05:42 2014 +0200 Fix 694084: compute number of segments in radial shading from radius. The above mentioned cracks can still appear, but I'll treat that as a separate issue. |