Bug 693467

Summary:	Obsolete Keys in .desktop integration
Product:	MuPDF	Reporter:	Michael Weber <gentoo>
Component:	mupdf	Assignee:	MuPDF bugs <mupdf-bugs>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	michael, robin.watts, tor.andersson
Priority:	P4
Version:	1.1
Hardware:	PC
OS:	Linux
Customer:		Word Size:	---

Description Michael Weber 2012-11-27 13:05:37 UTC

From https://bugs.gentoo.org/show_bug.cgi?id=444924

 * QA Notice: This package installs one or more .desktop files that do not
 * pass validation.
 * 
 *      /usr/share/applications/mupdf.desktop: error: action group "Desktop Action View" exists, but there is no matching action "View"
 *      /usr/share/applications/mupdf.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

Comment 1 Robin Watts 2013-02-28 11:34:25 UTC

I don't personally speak ".desktop" file - would you care to suggest a fixed version of the file? That'd move this along nicely.

None of the developers have a gentoo system to test on, so...

Thanks.

Comment 2 Michael Weber 2013-03-25 10:11:12 UTC

The test programm is desktop-file-validate from [1].
I added an patch to gentoo repository [2]


[2] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/mupdf/files/mupdf-1.1_p20121127-desktop-integration.patch?revision=1.1&view=markup


[1]  http://freedesktop.org/wiki/Software/desktop-file-utils

Comment 3 Robin Watts 2013-03-25 11:51:01 UTC

Thanks. I'll grab these changes in a mo.

Comment 4 Michael Weber 2013-03-25 16:52:01 UTC

(In reply to comment #3)
> Thanks. I'll grab these changes in a mo.

As mentioned in [1], please update to version 2 of the patchfile to fix both issues [2].

[1] http://bugs.ghostscript.com/show_bug.cgi?id=692943
[2] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/mupdf/files/mupdf-1.1_p20121127-desktop-integration.patch?revision=1.2&view=markup

Comment 5 Michael Weber 2013-06-08 11:12:05 UTC

You commit [1] missed the semicolon at the end of the Actions line.

/usr/share/applications/mupdf.desktop.orig: error: value "View" for string list key "Actions" in group "Desktop Entry" does not have a semicolon (';') as trailing character
/usr/share/applications/mupdf.desktop.orig: error: action group "Desktop Action View" exists, but there is no matching action "View"


--- /usr/share/applications/mupdf.desktop.orig  2013-06-08 13:05:42.769000000 +0200
+++ /usr/share/applications/mupdf.desktop       2013-06-08 13:06:15.727000000 +0200
@@ -8,7 +8,7 @@
 Type=Application
 MimeType=application/pdf;application/x-pdf;
 Categories=Viewer;Graphics;
-Actions=View
+Actions=View;
 
 [Desktop Action View]
 Name=View with mupdf

[1] http://git.ghostscript.com/?p=mupdf.git;a=commit;f=debian/mupdf.desktop;h=da1bb2862188bad205f3cbbba1fed0ab133234ab

Comment 6 Tor Andersson 2014-05-07 07:11:28 UTC

Irrelevant since we no longer supply debian packaging files.