| Summary: | [PATCH] Proposed device to compute ink coverage of a document | ||
|---|---|---|---|
| Product: | Ghostscript | Reporter: | Sebastian Kapfer <sebastian.kapfer> |
| Component: | General | Assignee: | Marcos H. Woehrmann <marcos.woehrmann> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | chris.liddell, pipitas |
| Priority: | P4 | ||
| Version: | master | ||
| Hardware: | All | ||
| OS: | All | ||
| Customer: | Word Size: | --- | |
| Attachments: | Patch implementing this | ||
|
Description
Sebastian Kapfer
2011-11-06 13:06:24 UTC
Created attachment 8081 [details]
Patch implementing this
As sent to the gs-devel list
Chris Lidell wrote: > Also, include in the report whether you would be willing to transfer > copyright to Artifex software (which would be preferable for us, > obviously!), or whether you'd want it distributed under the GPL license. Copyright assignment to Artifex is not a problem for me. > Finally, just a quick point I noticed your code uses the file operations > from the standard C library directly, and we generally prefer that such IO > happens through Ghostscript's own file APIs, as it keeps as much code as > possible platform independent, and makes porting *much* easier. This I don't quite understand, the C library functions should be very portable, no? Am I supposed to use FAPIU* from gxfapi.h instead? There doesn't seem to be a 'fprintf' function there, unfortunately. Cheers, Sebastian Assigned to Marcos to test with our standard test files for crashes. I've tested the device and it appears to work as advertised with no problem. I've contacted Miles to follow-up on the copyright assignment. Resolved in http://git.ghostscript.com/?p=ghostpdl.git;a=commit;h=70b1623bf91ea2a75da69f40caefb7efa56f49d9 Thanks to Sebastian Kapfer for the code and the copyright assignment. Will this device also work for GhostPDL (gxps, pcl6, gsvg)? > Will this device also work for GhostPDL (gxps, pcl6, gsvg)?
That would be very desirable. Does the device need to be very different to achieve that?
Devices are in the "graphics library" which is (generally) PDL angnostic, so the device will work fine with PCL/PXL/XPS. The only thing is, it may not be included in the builds for for the GhostPDL products by default, so it might need added. I've been trying to get it to work with a current local build from today's Git checkout. But I seem to be missing something. The inkcov device appears in the list of "gs -h" output. But my command gs -dNODISPLAY -sDEVICE=inkcov X.pdf doesn't return anything (other than the Ghostscript version signature on stderr and "Page 1"). I've been trying to get it to work with a current local build from today's Git checkout. But I seem to be missing something. The inkcov device appears in the list of "gs -h" output. But my command gs -dNOPAUSE -dBATCH -dNODISPLAY -sDEVICE=inkcov X.pdf doesn't return anything (other than the Ghostscript version signature on stderr, plus "Page 1"). Skipping the '-dNODISPLAY' part yields this: kp@mro:~/$ gs -sDEVICE=inkcov -dNOPAUSE -dBATCH X.pdf GPL Ghostscript GIT PRERELEASE 9.05 (2011-03-30) Copyright (C) 2010 Artifex Software, Inc. All rights reserved. This software comes with NO WARRANTY: see the file PUBLIC for details. Processing pages 1 through 1. Page 1 GPL Ghostscript GIT PRERELEASE 9.05: **** Could not open the file . Error: /invalidfileaccess in --showpage-- Operand stack: 1 true Execution stack: %interp_exit .runexec2 --nostringval-- --nostringval-- --nostringval-- 2 %stopped_push --nostringval-- --nostringval-- --nostringval-- false 1 %stopped_push 1894 1 3 %oparray_pop 1893 1 3 %oparray_pop 1877 1 3 %oparray_pop --nostringval-- --nostringval-- 2 1 1 --nostringval-- %for_pos_int_continue --nostringval-- --nostringval-- 1777 0 9 %oparray_pop --nostringval-- --nostringval-- Dictionary stack: --dict:1157/1684(ro)(G)-- --dict:1/20(G)-- --dict:82/200(L)-- --dict:82/200(L)-- --dict:109/127(ro)(G)-- --dict:291/300(ro)(G)-- --dict:24/31(L)-- --dict:6/8(L)-- --dict:21/40(L)-- Current allocation mode is local Last OS error: 2 GPL Ghostscript GIT PRERELEASE 9.05: Unrecoverable error, exit code 1 (In reply to comment #11) > Skipping the '-dNODISPLAY' part yields this: > > kp@mro:~/$ gs -sDEVICE=inkcov -dNOPAUSE -dBATCH X.pdf > GPL Ghostscript GIT PRERELEASE 9.05 (2011-03-30) > Copyright (C) 2010 Artifex Software, Inc. All rights reserved. > This software comes with NO WARRANTY: see the file PUBLIC for details. > Processing pages 1 through 1. > Page 1 > GPL Ghostscript GIT PRERELEASE 9.05: **** Could not open the file . > Error: /invalidfileaccess in --showpage-- Try setting -sOutputFile=... You *might* also have to leave off the -dNODISPLAY, IIRC, that installs the null page device. Thanks to Ken's hint I now found the shortest way to display a result: gs -o - -sDEVICE=inkcov X.pdf Which, in my case returns: Page 1 Substituting font Helvetica for ArialMT. Substituting font Helvetica-Oblique for Arial-ItalicMT. Substituting font Helvetica-Bold for Arial-BoldMT. 0.00000 0.00000 0.00000 0.07180 CMYK OK Page 1 Substituting font Helvetica for ArialMT. Substituting font Helvetica-Bold for Arial-BoldMT. Substituting font Helvetica-Oblique for Arial-ItalicMT. Substituting font Times-Italic for TimesNewRomanPS-ItalicMT. Substituting font Times-Roman for TimesNewRomanPSMT. 0.00000 0.00000 0.00000 0.05719 CMYK OK Page 1 Substituting font Helvetica for ArialMT. Substituting font Helvetica-Bold for Arial-BoldMT. Substituting font Helvetica-Oblique for Arial-ItalicMT. Substituting font Times-Italic for TimesNewRomanPS-ItalicMT. Substituting font Times-Roman for TimesNewRomanPSMT. 0.00000 0.00000 0.00000 0.05349 CMYK OK These commands also work as expected: gs -o X_inkcov.txt -sDEVICE=inkcov Y.pdf gs -o X_inkcov_page%03d.txt -sDEVICE=inkcov Y.pdf Kudos to Sebastian for adding an extremely useful tool/device to Ghostscript. Not everybody will have a use for it, but those who do will kiss his feet :-) I'll give it a better spin over the next few weeks, put it through my testing, and report back any issues I find. |