Bug 690949

Summary:	colorred pattern fill appeared with portion painted with black
Product:	Ghostscript	Reporter:	Hin-Tak Leung <htl10>
Component:	General	Assignee:	Hin-Tak Leung <htl10>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	bountiable
Priority:	P4
Version:	master
Hardware:	PC
OS:	Linux
Customer:		Word Size:	---
Bug Depends on:
Bug Blocks:	690585
Attachments:	paint through character

Description Hin-Tak Leung 2009-11-22 20:50:07 UTC

Bug688588.ps and Bug690160.ps (page 3) both have colorred/non-black pattern fills
rendered partly as black going pxlcolor then pcl6 to ppm.

Assigned to Marcos to try out on real PXL color printer to see whether it is
pxlcolor or pcl6 (pcl6->pdf shows colored patterns) before sending them onto
either me or Henry.

Comment 1 Marcos H. Woehrmann 2009-11-25 17:28:42 UTC

In both cases the issue appears to be with the pxlcolor device; sending the
Ghostscript generated pxl file to an HP ColorLaserJet 4500 results in output
that matches the GhostPCL output.

Comment 2 Hin-Tak Leung 2009-11-25 17:59:46 UTC

Thanks for the confirmation. Still a bit curious how pcl6->pdf looks different,
but I have filed a few 'pcl6->pdf looks different from ppm' already, and it
might just go away when those are fixed. 

I'll look properly why pattern fill is losing color in the middle - it appears
that incomplete pattern tiles (those are at the edge) are colored correctly
while complete ones (in the middle) are not.

Comment 3 Hin-Tak Leung 2009-11-27 01:13:23 UTC

Created attachment 5723 [details]
paint through character

set ROP to paint through character glyphs (pattern tiles).

Apparently complete pattern tiles are sent as a character in a custom symbol
font (rather than small rectangles for incomplete tiles), thus allowing re-use.
The code set the fill color but never set ROP to "paint with brush color" thus
glyphs appears as black. This patch set the ROP3 operation to paint through
complete pattern tiles. This should also fix the bulk of the problems in bug
690585 (for ghostpdl).

Comment 4 Hin-Tak Leung 2010-01-19 13:53:27 UTC

patch was commited as r10403, and showed okay from Marcos before Christmas.