Bug 694365 - Paths to header files need updating in Makefile's install target.
Paths to header files need updating in Makefile's install target.
Status: RESOLVED FIXED
Product: MuPDF
Classification: Unclassified
Component: fitz
master
PC Linux
: P4 major
Assigned To: Tor Andersson
Bug traffic
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-20 07:32 PDT by Gaetan Bisson
Modified: 2013-06-28 08:03 PDT (History)
3 users (show)

See Also:
Customer:
Word Size: ---


Attachments
Patch updating the paths to header files in Makefile's install. (677 bytes, application/octet-stream)
2013-06-20 07:32 PDT, Gaetan Bisson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gaetan Bisson 2013-06-20 07:32:22 PDT
Created attachment 10003 [details]
Patch updating the paths to header files in Makefile's install.

Commit 270694d6a1a78bb9a530185762c07faeac1f0e7f "Move header files into separate include directory" forgot to update the hardcoded locations of said header files in the install target of the Makefile.

The attached patch fixes this, but note that it still uses hardcoded paths (because $(FITZ_HDR) and $(PDF_HDR) contain more headers than should be installed).
Comment 1 Michael Weber 2013-06-20 08:47:21 PDT
This results in /usr/include/{memento.h,fitz.h,pdf.h,xps.h,cbz.h,image.h}.
At least /usr/include/image.h is very unspecific and might result in file collisions.
I think the intentions was to install these files into /usr/include/mupdf/.

This restructuring breaks llpp, which includes mupdf-internal.h muxps-internal.h (but, to my disappointment, build it's own copy of mupdf, specified by a git commit)
http://repo.or.cz/w/llpp.git/blob/HEAD:/link.c

zathura-pdf-mupdf will miss it, too.
https://git.pwmt.org/?p=zathura-pdf-mupdf.git;a=blob;f=pdf.c;h=dad3c7985011e5e128bf5766ea83978f7bedf851;hb=HEAD
Comment 2 Michael Weber 2013-06-20 09:31:06 PDT
and the mupdf/fitz.h does include mupdf/fitz/<a lot of stuff>.h as does mupdf/pdf.h, acutally, you need the whole include tree from the tarball.

I added this for Gentoo 
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/mupdf/files/mupdf-9999-install-headers.patch?revision=1.1&view=markup
Comment 3 Robin Watts 2013-06-20 09:49:32 PDT
Thanks for the report guys. As you have no doubt noticed, MuPDF is undergoing a big reshuffle of its source code at the moment. Give us a few days to complete it, and hopefully it'll all shake out to something that works as you expect.

The plan is that we should install headers into /usr/include/mupdf/