Created attachment 6644 [details] config.log The configure script fails because the system lib tiff is out of date but we should be using the internal tiff library by default.
Looks like a logical error in configure.ac, the code is checking the system library after it is established the local tiff library should be used. Copied in Lars for feedback. Here's a patch, untested on ubuntu 8.04 Index: configure.ac =================================================================== --- configure.ac (revision 11622) +++ configure.ac (working copy) @@ -548,10 +548,11 @@ LIBTIFFDIR=tiff LOCAL_LIBTIFF_VERSION=`sed -n '/TIFFLIB_VERSION[[^_]]/s/[[^0-9]]*\([[0-9]]*\).*/\1/p' $LIBTIFFDIR/libtiff/tiffvers.h` SHARE_LIBTIFF=0 - fi - AC_CHECK_LIB(tiff, TIFFOpen, + else + AC_CHECK_LIB(tiff, TIFFOpen, [AC_CHECK_HEADERS(tiff.h, [HAVE_SYSTEM_LIBTIFF=1;SHARE_LIBTIFF=1])], [], [-ljpeg]) + fi if test -z $LOCAL_LIBTIFF_VERSION && test "x$HAVE_SYSTEM_LIBTIFF" = x; then AC_MSG_NOTICE([Could not find a copy of libtiff on your system. Disabling tiff output devices.])
I can't reproduce this problem on Ubuntu 8.04.4. My 8.04.4 virtual machine has been updated, and I don't have a vanilla 8.04 install. But 8.04.4 appears to have the same libtiff installed as 9.10 (version 3.8.2 with TIFFLIB_VERSION==20060323), so I would expect that to exhibit the same problem. Regardless of that, I've looked at Henry's patch, and it does look correct where the old code doesn't, and I've tested it on Ubuntu 8.04.4 and it works as expected (but then, for me it did before, too). I'm happy with the proposed change.
fixed in r11635
Sorry for being late, but I didn't have a chance to take a look at this before today. The idea was not to always prefer the local version if libtiff (unless forced with --with-system-libtiff=no), but to check the versions and use the latest of the two. This is what the code did prior to Henry's patch. This patch always favors the local version, even if the system's libtiff is newer. The original problem in the attached config.log is not at all related to libtiff, but due to jasper's configure script failing (line 819). The libtiff-related stuff in the log is the program failing which compares the version strings of the local and system versions of libtiff. This is by design and the error is caught. I propose to revert the patch.
(In reply to comment #4) > Sorry for being late, but I didn't have a chance to take a look at this before > today. > > The idea was not to always prefer the local version if libtiff (unless forced > with --with-system-libtiff=no), but to check the versions and use the latest of > the two. This is what the code did prior to Henry's patch. This patch always > favors the local version, even if the system's libtiff is newer. > > The original problem in the attached config.log is not at all related to > libtiff, but due to jasper's configure script failing (line 819). The > libtiff-related stuff in the log is the program failing which compares the > version strings of the local and system versions of libtiff. This is by design > and the error is caught. > > I propose to revert the patch. We do want the default system to use the internal libtiff by default.
Created attachment 6668 [details] Patch: Remove unnecessary version checks for libtiff I'll apply the patch after the freeze.
Committed in r11648.
Changing customer bugs that have been resolved more than a year ago to closed.