Bug 690601 - initialize internal_symbol_sets before internal_fonts
Summary: initialize internal_symbol_sets before internal_fonts
Status: NOTIFIED FIXED
Alias: None
Product: GhostPCL
Classification: Unclassified
Component: PCL interpreter (show other bugs)
Version: master
Hardware: PC Windows XP
: P2 normal
Assignee: Henry Stiles
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-06 01:32 UTC by norbert.janssen
Modified: 2011-09-18 21:47 UTC (History)
0 users

See Also:
Customer: 661
Word Size: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description norbert.janssen 2009-07-06 01:32:08 UTC 
in pcl_set_current_font_environment() the built_in_fonts are loaded. But before
you could use them, the built_in_symbol_sets should be available.
At this point (during pcl_reset_initial) the symbolsets are not yet installed.
See pcl_init_table[] in pctop.c, pcfont_init is before pcsymbol_init.

I think that pcsymbol_init should be executed before pcfont_init.
Comment 1 Henry Stiles 2009-07-06 10:30:19 UTC 
We'd like initialization to be free from ordering, there are cases where this is
not possible, but it isn't clear this is one of the cases.  Is there an
uninitialized read or a bug associated with this?
Comment 2 norbert.janssen 2009-07-06 11:02:27 UTC 
During font-init the pcs->built_in_symbolset is not installed yet.
In pcl_set_current_font_environment() the fontnumber is loaded. If the font is
bound (i.e. SYMBOL), this also requires the SYMBOLSET to be set.
For compatibility with our other interpreter I wanted to see if I could do this
automagically. (See also the NB: comment on the fontnumber being stepped on).
Comment 3 Henry Stiles 2009-08-02 21:45:00 UTC 
fixed in rev 9929.
Comment 4 Marcos H. Woehrmann 2011-09-18 21:47:59 UTC 
Changing customer bugs that have been resolved more than a year ago to closed.