Bug 689788 - User suggested improvement to Ghostscript build
Summary: User suggested improvement to Ghostscript build
Status: NOTIFIED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Build Process (show other bugs)
Version: 8.62
Hardware: Macintosh MacOS X
: P4 normal
Assignee: Ralph Giles
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-09 12:09 UTC by Marcos H. Woehrmann
Modified: 2008-12-19 08:31 UTC (History)
0 users

See Also:
Customer:
Word Size: ---

Attachments
patch (2.17 KB, patch)
2008-04-09 12:10 UTC, Marcos H. Woehrmann 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos H. Woehrmann 2008-04-09 12:09:35 UTC 
A user, Hauke Klein <klein@math.uni-kiel.de>, sent the attached patch along with this email;

while building ghostscript 8.62 with non-standard settings for GLGENDIR, GLOBJDIR, ...
I noticed a few small inconsistencies in ghostscripts makefiles. The attached patch should
fix these. I'm also building with a separate build directory. Unfortunately, the resulting path
strings overflow a static buffer in echogs.c. The patch also changes the size of these
buffers. I'm just including limits.h, I should probably guard this with an HAVE_LIMITS_H
or something like this.
Comment 1 Marcos H. Woehrmann 2008-04-09 12:10:27 UTC 
Created attachment 3927 [details]
patch
Comment 2 Ralph Giles 2008-04-10 16:46:15 UTC 
Fixes committed in r8634 and r8635. We don't use PATH_MAX (or FILENAME_MAX
or...) because it's not reliably defined, so I just bumped it from an arbitrary
100 to an arbitrary 1000.

Thanks for the report.