Bug 689780 - src/rinkj/rinkj-byte-stream.c:79 implicit declaration of function free
Summary: src/rinkj/rinkj-byte-stream.c:79 implicit declaration of function free
Status: NOTIFIED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: Build Process (show other bugs)
Version: 8.62
Hardware: PC Linux
: P4 normal
Assignee: Ralph Giles
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-02 10:56 UTC by Sandro Bonazzola
Modified: 2008-12-19 08:31 UTC (History)
0 users

See Also:
Customer:
Word Size: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sandro Bonazzola 2008-04-02 10:56:44 UTC
Building the package the compiler warns about undeclared function xfree in
src/rinkj/rinkj-byte-stream.c.

The package seems to work fine for now but as a good programming practice,
please fix the missing declaration.
Comment 1 Ralph Giles 2008-04-02 11:03:46 UTC
There is no xfree() called from the rinkj code (or anywhere else outside the X11
device driver). Can you check what's remapping free to xfree in your build?
Comment 2 Sandro Bonazzola 2008-04-02 11:16:15 UTC
Sorry, I've added an x that weren't in the file due to coloring of the output
done by the checker script.
The undeclared function is free, not xfree, at line 79 of
src/rinkj/rinkj-byte-stream.c.

Comment 3 Ralph Giles 2008-04-03 18:04:23 UTC
Should be corrected in r8618.

If I can ask a silly question, what version of Ghostscript are you using? The
version of gdevrinkj.c included in the 8.62 release doesn't compile, and so far
as I can tell never has. It was never enabled in the standard build, so it looks
like we didn't notice we had an incomplete version in the repository.
Comment 4 Sandro Bonazzola 2008-04-07 11:59:56 UTC
I'm using Gentoo app-text/ghostscript-gpl-8.62: patches applied to ghostscript-8.62:
http://mirror.switch.ch/ftp/mirror/gentoo/distfiles/ghostscript-gpl-8.62-patchset-1.tar.bz2
compiled with: http://mirror.switch.ch/ftp/mirror/gentoo/distfiles/gsdjvu-1.3.tar.gz

Comment 5 Ralph Giles 2008-04-08 14:46:51 UTC
Ah, distro patches are every so often accidentally sent upstream like this... :)

Anyway, I made a similar change to the gentoo rinkj patch in r8619, so that
explains how it was building for you.