Bug 689712 - macro expanded unnecessarily and undocumented .h file
Summary: macro expanded unnecessarily and undocumented .h file
Status: NOTIFIED FIXED
Alias: None
Product: Ghostscript
Classification: Unclassified
Component: PDF Writer (show other bugs)
Version: master
Hardware: Macintosh MacOS X
: P4 normal
Assignee: Ken Sharp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-18 19:48 UTC by Henry Stiles
Modified: 2008-12-19 08:31 UTC (History)
1 user (show)

See Also:
Customer:
Word Size: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Stiles 2008-02-18 19:48:49 UTC 
On Sun Feb 17 22:33:33 CST 2008, L Peter Deutsch
<ghost@major2nd.com> wrote:
> * gdevpdtf.h includes an executable statement
> gs_private_st_basic(...) at
>   line 188.  This causes a redundant copy of the st_pdf_base_font
> data
>   structure to be included in every .c file that #includes
> gdevpdtf.h, of
>   which there are 12.
>
> * gdevpdtv.h has no comments it whatsoever.  Furthermore, it's
> only used in
>   one .c file (gdevpdtw.c), so its contents probably shouldn't be
> in a .h
>   file at all.
Comment 1 leonardo 2008-03-26 11:06:50 UTC 
The files gdevpdtv.c, gdevpdtv.h has been generated with encs2c.ps . Alex did 
this enhancement to encs2c.ps upon my request.
Comment 2 Ken Sharp 2008-04-04 01:56:31 UTC 
This patch:

http://ghostscript.com/pipermail/gs-cvs/2008-April/008207.html

resolves the problem. Includes additional commenting from the auto-generator
encs2c.ps in an attempt to ensure this does problem not recur.