Summary: | ghostscript-8.71 fails to compile against >=libpng-1.4.0 | ||
---|---|---|---|
Product: | Ghostscript | Reporter: | Timo Gurr <timo.gurr> |
Component: | Build Process | Assignee: | Hin-Tak Leung <htl10> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P4 | ||
Version: | 0.00 | ||
Hardware: | PC | ||
OS: | Linux | ||
URL: | http://bugs.gentoo.org/show_bug.cgi?id=305111 | ||
Customer: | Word Size: | --- | |
Attachments: |
ghostscript-gpl-8.71-libpng-1.4.0-compile-fix.patch
ghostscript-gpl-8.71-libpng-1.4.0-compile-fix-v2.patch |
Description
Timo Gurr
2010-02-15 13:40:46 UTC
Created attachment 5955 [details]
ghostscript-gpl-8.71-libpng-1.4.0-compile-fix.patch
Created attachment 6041 [details]
ghostscript-gpl-8.71-libpng-1.4.0-compile-fix-v2.patch
Grabbing a Ralph's bugs. (In reply to comment #2) > Created an attachment (id=6041) [details] > ghostscript-gpl-8.71-libpng-1.4.0-compile-fix-v2.patch Sorry, the patch is wrong - in 1.4.0, png_check_sig() is removed and replaced by png_sig_cmp() so applying it would break building against linpng 1.2.x . It would be far better to modify configure to check for a function which is common to both 1.2.x and 1.4.x, rather than switching between the two. e.g. check if png_struct is defined or png_create_write_struct() is defined. (these are actually used by the png device so rather more appropriate than either png_check_sig() or png_sig_cmp()). r11449 switches the png test away from png_sig_cmp() (obsolete/removed in libpng 1.4) to png_create_write_struct() which is actually used by the png device, and common to both libpng 1.2.x and 1.4.x , to allow building against either versions. As explained, the submitted patch was wrong. Also, configure.ac is usually sym-link to "base/configure.ac", so only two files needed to be modified, rather than three. |